Skip to content

Eng 2306#7

Merged
Philippoes merged 3 commits intomainfrom
eng-2306
Apr 15, 2026
Merged

Eng 2306#7
Philippoes merged 3 commits intomainfrom
eng-2306

Conversation

@Ishita-02
Copy link
Copy Markdown
Collaborator

@Ishita-02 Ishita-02 commented Apr 14, 2026

Summary by CodeRabbit

  • Documentation

    • Added comprehensive reference for Privy Intent Webhooks: dashboard setup, supported intent lifecycle events, payload structures, delivery semantics, retry policies, signature verification guidance, and IP allowlisting.
  • New Features

    • Optional workflow prompt to let users configure Privy webhooks for real-time notifications on intent creation, authorization, execution, and failure.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 14, 2026

📝 Walkthrough

Walkthrough

Added a new Privy webhook reference file and a prompt in the semi-autonomous workflow to optionally configure webhooks; SKILL.md's Reference Files list was updated to include the new webhook doc. No runtime logic or public API signatures were changed.

Changes

Cohort / File(s) Summary
Privy Webhook Documentation
yield-agentkit-skills/skills/yield-agentkit-privy/SKILL.md, yield-agentkit-skills/skills/yield-agentkit-privy/references/privy-webhooks.md
Added privy-webhooks.md and registered it in SKILL.md; documents intent lifecycle events (intent.created, intent.authorized, intent.executed, intent.failed), payload schemas, delivery semantics, retry policies, idempotency handling, IP allowlisting, and signature verification examples (including @privy-io/node).
Semi-Autonomous Workflow
yield-agentkit-skills/skills/yield-agentkit-privy/references/semi-autonomous.md
Inserted a user prompt after wallet/quorum setup offering optional Privy webhook setup; if accepted, directs users to the new webhook reference before resuming the workflow.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • Philippoes
  • apurvmishra
  • 0xYoki

Poem

🐇 I hopped through docs with eager cheer,
Webhooks ringing, crystal clear,
Intent bells toll from create to fail,
I left a trail so teams prevail,
Hop on, configure, watch events appear.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The pull request title 'Eng 2306' is not descriptive; it appears to be a task ID rather than a meaningful summary of the changes. Use a descriptive title that summarizes the main change, such as 'Add Privy Intent Webhooks documentation and setup guide' or 'Document Privy webhook integration for real-time intent notifications'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch eng-2306

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@yield-agentkit-skills/skills/yield-agentkit-privy/references/privy-webhooks.md`:
- Line 95: The doc line for action_result.authorized_by_id is incorrect: it
currently says "ID of the authorizing quorum member" but should state it's the
key quorum ID as defined in the intent-webhooks reference; update the
description for action_result.authorized_by_id to "ID of the authorizing key
quorum" (or similar wording matching intent-webhooks) and add a brief note or
cross-reference to the intent-webhooks specification to avoid future confusion.
- Around line 114-120: The fenced code block containing the IP list (the block
starting with "44.228.126.217" and ending with "2600:1f24:64:8000::/56") needs a
language tag to satisfy MD040; update the opening fence from ``` to ```text (or
another appropriate language) in the privy-webhooks.md file so the block is
lint-compliant while keeping the IP lines unchanged.
- Around line 130-134: The call to privy.webhooks().verify is using the old
positional/header-style signature; update the call to use the current object
form by passing an object with payload and a svix sub-object. Specifically,
replace the existing privy.webhooks().verify(requestBody, { "svix-id":
req.headers["svix-id"], "svix-timestamp": req.headers["svix-timestamp"],
"svix-signature": req.headers["svix-signature"] }) usage so that verify receives
{ payload: requestBody, svix: { id: req.headers["svix-id"], timestamp:
req.headers["svix-timestamp"], signature: req.headers["svix-signature"] } }
ensuring the variable payload (or requestBody) and header values are mapped to
id/timestamp/signature fields for privy.webhooks().verify.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e718fc8e-15a9-463e-82bd-c8e69d1f6c5f

📥 Commits

Reviewing files that changed from the base of the PR and between 62a9041 and 92dc907.

📒 Files selected for processing (3)
  • yield-agentkit-skills/skills/yield-agentkit-privy/SKILL.md
  • yield-agentkit-skills/skills/yield-agentkit-privy/references/privy-webhooks.md
  • yield-agentkit-skills/skills/yield-agentkit-privy/references/semi-autonomous.md

Comment thread yield-agentkit-skills/skills/yield-agentkit-privy/references/privy-webhooks.md Outdated
Comment thread yield-agentkit-skills/skills/yield-agentkit-privy/references/privy-webhooks.md Outdated
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@yield-agentkit-skills/skills/yield-agentkit-privy/references/privy-webhooks.md`:
- Around line 139-146: Change the incorrect function-call usage of the webhooks
API: replace the call to privy.webhooks().verify(...) with the property-style
call privy.webhooks.verify(...). Locate the verification call where
verifiedPayload is assigned (symbol: verifiedPayload and method call
privy.webhooks().verify) and remove the parentheses after webhooks so the code
uses privy.webhooks.verify with the same payload and svix arguments.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a66aa8f1-6388-403a-9790-c03f8ffc9efe

📥 Commits

Reviewing files that changed from the base of the PR and between 92dc907 and 3145cc9.

📒 Files selected for processing (1)
  • yield-agentkit-skills/skills/yield-agentkit-privy/references/privy-webhooks.md

@Philippoes Philippoes merged commit 5195544 into main Apr 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants